Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Laravel 9 support using Symfony Mailer #173

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Add Laravel 9 support using Symfony Mailer #173

merged 2 commits into from
Mar 30, 2022

Conversation

ajohnson6494
Copy link
Contributor

@ajohnson6494 ajohnson6494 commented Mar 9, 2022 •
edited
Loading

This PR implements the new Symfony Mailer that was introduced in Laravel 9. This PR do introduce some breaking changes, so it is my recommendation to release this as version 5 of this package.

Special thanks to @stayallive for providing a great starting point for this update.

Closes #169

@ajohnson6494 ajohnson6494 mentioned this pull request Mar 17, 2022
Closed
@shawkiIIalasy
Copy link

shawkiIIalasy commented Mar 17, 2022 •
edited
Loading

@fedeisas @sietzekeuning Please check this one

@sietzekeuning
Copy link
Contributor

Looks good to me!

@shawkiIIalasy
Copy link

@fedeisas Please check

@jimleeder123
Copy link

Any updates on when this will be released, please?

@PostScripton
Copy link

PostScripton commented Mar 30, 2022 •
edited
Loading

Good day, @ajohnson6494!
I'm using your branch Laravel9, but I encountered an issue:

ReflectionException: Class Fedeisas\LaravelMailCssInliner\SymfonyMailerCssInliner does not exist

So I decided to clone your branch to take a look at what is going on. And then I saw this:

src/LaravelMailCssInlinerServiceProvider.php
image

You haven't specified, or even created, a listener SymfonyMailerCssInliner. Let me know when you fix this as soon as possible, please.
Thank you in advance!

@PostScripton
Copy link

@ajohnson6494
According to tests, I believe, it should look like this:

src/LaravelMailCssInlinerServiceProvider.php:
https://user-images.githubusercontent.com/68855126/160815660-57035be1-b827-4733-b433-5e51556be825.png

src/Listeners/SymfonyMailerCssInliner.php:
https://user-images.githubusercontent.com/68855126/160815841-429d20b6-6f0e-49d7-b214-75e2cb380380.png

And, definetely, do not forget to rename the config file and its key.

Correct me, if I'm wrong 😄

@ajohnson6494
Copy link
Contributor Author

@PostScripton Thanks for finding that, I have made a few updates, let me know if that is working better now.

@fedeisas fedeisas merged commit a513014 into fedeisas:master Mar 30, 2022
@QusaiFarraj
Copy link

@fedeisas Thanks for merging this PR into master.

Can you publish a new tag for this upgrade?

Thanks in advance!

@phanan
Copy link

phanan commented Apr 7, 2022

@fedeisas Sorry for the ping, but how soon can you tag a new release please?

@archfrog
Copy link

Ouch, I just upgraded a project to Laravel v9 and now I'm stuck with a live server that generates ugly mails. Please release v5 soon :-) Meanwhile, I'll spend some "quality" time inlining my tags manually.

@mahmoudAkobah
Copy link

@fedeisas Sorry to bother you, any plans to release this PR any time soon

@shawkiIIalasy
Copy link

@fedeisas Could you please release this?

@phanan
Copy link

phanan commented May 16, 2022

FWIW we decided to stop using this package and move all CSS to <head>, as support for <style> in <head> is actually pretty good these days: https://www.campaignmonitor.com/css/style-element/style-in-head/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Someday Laravel 9
10 participants
@ajohnson6494 @shawkiIIalasy @sietzekeuning @jimleeder123 @PostScripton @QusaiFarraj @phanan @archfrog @mahmoudAkobah @fedeisas