Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separated namespace for document #11

Merged
merged 2 commits into from
Feb 1, 2018

Conversation

totakke
Copy link
Collaborator

@totakke totakke commented Feb 1, 2018

Adds a new namespace, clucie.document, for document-related features.

I moved Document/Field/FieldType generators and Document -> map converter from clucie.core. Arities and docstrings of these functions were reconsidered, and now they can be easily used as public functions. In the near future, I'd like to add useful wrappers of sugar fields, such as StringField and SortedNumericDocValuesField.

@codecov-io
Copy link

codecov-io commented Feb 1, 2018

Codecov Report

Merging #11 into master will increase coverage by 0.17%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage    88.7%   88.88%   +0.17%     
==========================================
  Files           4        5       +1     
  Lines         186      189       +3     
  Branches       14       14              
==========================================
+ Hits          165      168       +3     
  Misses          7        7              
  Partials       14       14
Impacted Files Coverage Δ
src/clucie/core.clj 80.76% <66.66%> (-3.5%) ⬇️
src/clucie/document.clj 93.93% <93.93%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c690d82...3e0a4da. Read the comment docs.

@federkasten federkasten self-requested a review February 1, 2018 15:06
@federkasten federkasten self-assigned this Feb 1, 2018
@federkasten federkasten merged commit 210196a into federkasten:master Feb 1, 2018
@federkasten
Copy link
Owner

Thank you. Looks good PR.

I have granted you a collaborator of clucie project. Could you help me to improve this library?

@totakke totakke deleted the feature/document-ns branch February 2, 2018 01:04
@totakke
Copy link
Collaborator Author

totakke commented Feb 2, 2018

Thanks! I gladly accept your offer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants