feat: confirm password field #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbobeirne
requested changes
Nov 1, 2023
wbobeirne
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "Confirm password" field, might also want to put the "click to view password" options.
Had an issue with a federation setup today: 1 guardian forgot their password after clicking away rom the "verification codes" section of federation setup. this meant that the guardian couldn't continue setup and all the other guardians were already in a state waiting for that specific guardian and couldn't do a hard reset, which bricked the entire federation.
@wbobeirne @sethwynne plz fix so it looks nice and fits UI scheme but until fedimint allows for hard reset having this as a backstop will be useful.