feat: scroll to top on progress screen change #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We probably need to smoothen/animate the scroll to top. any feedback on this experience, @wbobeirne ? |
|
The current behavior here is very annoying. Also defer to @wbobeirne about how to fix. |
|
I can make it smooth I preferred just jumping to top, fine with either |
|
I'll look at this one today, sorry for the delay. |
|
Typical web behavior is that new pages jump to the top immediately on navigation, not smoothly, so that's what I'd advocate for. I think Kody's initial behavior was closer to a normal web experience. |
wbobeirne
force-pushed
the
scroll-to-top
branch
from
0d2530e
to
87a8fc8
Compare
wbobeirne
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.