Block confs warning #281
Merged
Block confs warning #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kodylow
force-pushed
the
block-confs-warning
branch
from
e7b9e07
to
3144838
Compare
fix: change langauge chore: fedimint block confirmations warning
Kodylow
force-pushed
the
block-confs-warning
branch
from
0c71eb0
to
77232d8
Compare
okjodom
approved these changes
Nov 13, 2023
wbobeirne
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #280
What should the recommended minimum be here and any recommendations on copy for the warning? Should I have it link to a more in-depth explanation in the fedimint docs?