-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Role selector Mobile Updates #298
Role selector Mobile Updates #298
Conversation
I don't like the "Are you creating a federation or joining one" at all, it just seems unnecessary especially since the creating or joining aren't easily visually mapped to setup vs guardian from that position, I think we should drop it |
f1f177e
to
a30a41e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small code notes in here.
I'm not sure how we want to come to consensus around copy changes. For the most part I agree with the idea behind these changes, but it's going to get hard to decide a source of truth for copy if we start calling audibles in PRs.
I'm pretty ok with these but want to give a sec for others to weigh in.
@@ -116,7 +116,7 @@ | |||
"title": "Terms of service" | |||
}, | |||
"start": { | |||
"title": "Welcome to Fedimint!", | |||
"title": "Welcome, Guardian!", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you update existing keys in english, you need a way to make sure they get re-translated for other languages, otherwise there'll be a mismatch. This either means doing the translation yourself, or removing the keys to allow them to be re-translated later.
I don't love the way this works right now, and I'm open to alternative approaches if anyone's got ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed and translated w google, will wait on what others say about how to update copy, I'll just add these as comments on figma
Makes several changes to the Role Selector page:
Old:
New: