Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role selector Mobile Updates #298

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

Kodylow
Copy link
Member

@Kodylow Kodylow commented Nov 14, 2023

Makes several changes to the Role Selector page:

Old:
image

New:

image
  1. Updates to copy:
  • Change to "Welcome, Guardian" to avoid stacking big "Fedimint" and make it easier to fit title on mobile screen
  • Setup Leader: slarifies that it's just for setup, not a difference among guardians
  • Follower: Clarifies their role as after setup leader and that that's when the actual federation gets set up.
  • Removes mainnet warning: we should do the mainnet warnings on the leader configuration page if they actually select mainnet, not preemptively. Also tells ppl to file issues with us.
  1. Moves warning below role selector, above next button:
  • On mobile the big warning pushes the follower option below the fold, this looks and makes it more like an "acknowledge by clicking next"
  1. Fixes mobile UI layout
  • Fixes overflows in radiobuttongroup children
  • centers header on mobile (will be centered across all mobile pages)
  • 100% width for next button

@Kodylow
Copy link
Member Author

Kodylow commented Nov 14, 2023

I don't like the "Are you creating a federation or joining one" at all, it just seems unnecessary especially since the creating or joining aren't easily visually mapped to setup vs guardian from that position, I think we should drop it

Copy link
Collaborator

@wbobeirne wbobeirne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small code notes in here.

I'm not sure how we want to come to consensus around copy changes. For the most part I agree with the idea behind these changes, but it's going to get hard to decide a source of truth for copy if we start calling audibles in PRs.

I'm pretty ok with these but want to give a sec for others to weigh in.

packages/ui/src/RadioButtonGroup.tsx Outdated Show resolved Hide resolved
@@ -116,7 +116,7 @@
"title": "Terms of service"
},
"start": {
"title": "Welcome to Fedimint!",
"title": "Welcome, Guardian!",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you update existing keys in english, you need a way to make sure they get re-translated for other languages, otherwise there'll be a mismatch. This either means doing the translation yourself, or removing the keys to allow them to be re-translated later.

I don't love the way this works right now, and I'm open to alternative approaches if anyone's got ideas.

Copy link
Member Author

@Kodylow Kodylow Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed and translated w google, will wait on what others say about how to update copy, I'll just add these as comments on figma

packages/ui/src/RadioButtonGroup.tsx Outdated Show resolved Hide resolved
packages/ui/src/RadioButtonGroup.tsx Outdated Show resolved Hide resolved
packages/ui/src/RadioButtonGroup.tsx Outdated Show resolved Hide resolved
apps/guardian-ui/src/setup/FederationSetup.tsx Outdated Show resolved Hide resolved
@wbobeirne wbobeirne merged commit d6fd00e into fedimint:master Nov 15, 2023
1 check passed
@wbobeirne wbobeirne mentioned this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants