Verify configs mobile UI #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okjodom
previously approved these changes
Nov 20, 2023
|
I just did a bunch of updates here lmk if you guys have time to test and merge @wbobeirne @okjodom |
@Kodylow, I'm super confused by the two commits added in latest iteration. They are tangential to the original purpose of this PR, commit messages don't make sense Could we keep the original change atomic as reviewed? we can start "Reset" experience in a new workstream & PR |
|
Yeah sorry didn't realize I was on that same branch will refactor commits |
Kodylow
force-pushed
the
verify-configs-mobile-ui
branch
from
068858b
to
b955c50
Compare
|
@okjodom just moved those to separate branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Verify Configs page for mobile UI: