Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify guardian api implementation #315

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

okjodom
Copy link
Collaborator

@okjodom okjodom commented Nov 20, 2023

makes guardian api type declaration and implementation simpler 🖌️

closes #176

@okjodom okjodom marked this pull request as ready for review November 22, 2023 01:29
@okjodom okjodom requested a review from a team as a code owner November 22, 2023 01:29
@okjodom
Copy link
Collaborator Author

okjodom commented Nov 22, 2023

@wbobeirne pls take a look when you have the time. hopefully we can build on top of this for #316

@okjodom okjodom force-pushed the rf-api branch 3 times, most recently from e9716c4 to 1033a80 Compare November 27, 2023 20:36
wbobeirne
wbobeirne previously approved these changes Nov 27, 2023
Copy link
Collaborator

@wbobeirne wbobeirne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already an improvement so I'm ok with it going in as-is, but some suggestions that could make this even better.

apps/guardian-ui/src/types.tsx Outdated Show resolved Hide resolved
@Kodylow Kodylow merged commit cd378e5 into fedimint:master Jan 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify GuardianApi types & implementation
3 participants