Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: solo-guardians #325

Merged
merged 2 commits into from
Nov 30, 2023
Merged

feat: solo-guardians #325

merged 2 commits into from
Nov 30, 2023

Conversation

Kodylow
Copy link
Member

@Kodylow Kodylow commented Nov 28, 2023

Adds solo guardian changes from pair programming with justin and will

@Kodylow Kodylow requested a review from a team as a code owner November 28, 2023 19:28
wbobeirne
wbobeirne reviewed Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@wbobeirne wbobeirne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This copy needs updating

CleanShot 2023-11-30 at 09 50 22@2x

At some point in the future, we should probably just get rid of this since these steps don't really happen for solo, but not important for this PR.

CleanShot 2023-11-30 at 09 50 19@2x

apps/guardian-ui/src/components/RoleSelector.tsx Outdated Show resolved Hide resolved
wbobeirne
wbobeirne previously approved these changes Nov 30, 2023
View reviewed changes
@wbobeirne wbobeirne merged commit 1ac536f into fedimint:master Nov 30, 2023
1 check passed
@okjodom okjodom mentioned this pull request Jan 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbobeirne wbobeirne wbobeirne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kodylow @wbobeirne