fix: mutinynet url matching #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbobeirne
requested changes
Nov 30, 2023
Kodylow
force-pushed
the
mutinynet-trailing-slash
branch
from
bcdb110
to
d16c277
Compare
|
updated and refactored out to separate the check. |
wbobeirne
requested changes
Dec 5, 2023
packages/ui/src/NetworkIndicator.tsx
Outdated
| const isMutinynet = (bitcoinRpcUrl: string) => { | ||
| try { | ||
| const url = new URL(bitcoinRpcUrl); | ||
| return url.host === 'mutinynet.com' && url.pathname === '/api'; |
There was a problem hiding this comment.
This still doesn't work, do you just want to drop the pathname and make it mutinynet if it's from mutinynet.com?
wbobeirne
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that if you have a trailing slash on the https://mutinynet.com/api/ rpc it doesn't register as mutinynet, so this converts to URL to match against trailing slash and http