fix: overwrite numPeers to 1 for solo #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbobeirne
requested changes
Dec 1, 2023
| @@ -189,7 +189,7 @@ export const SetConfiguration: React.FC<Props> = ({ next }: Props) => { | |||
| myName, | |||
| password, | |||
| configs: { | |||
| numPeers: parseInt(numPeers, 10), | |||
| numPeers: isSolo ? 1 : parseInt(numPeers, 10), | |||
There was a problem hiding this comment.
This might work, but might also be a little buggy since there's also some isSolo consideration up at line 65:
const [numPeers, setNumPeers] = useState(
stateNumPeers ? stateNumPeers.toString() : isSolo ? '1' : '4'
);We should do this in only one place so they don't get out of sync, either only here and delete the logic up there, or only up there by changing the logic up there to:
isSolo ? '1' : stateNumPeers ? stateNumPeers.toString() : '4'
Kodylow
force-pushed
the
numPeers-1-solo
branch
from
e5bbbd4
to
cdef0b4
Compare
Kodylow
force-pushed
the
numPeers-1-solo
branch
from
cdef0b4
to
a943d0d
Compare
wbobeirne
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case they go back and forth on the role selector.