Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decode string responses as json for address and deposit txid #340

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

wbobeirne
Copy link
Collaborator

Closes #338. Replaces both instances of a string response with res.json(), not just for objects after all!

@wbobeirne wbobeirne requested a review from a team as a code owner December 5, 2023 19:24
Copy link
Member

@Kodylow Kodylow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@wbobeirne wbobeirne merged commit 7a5acc4 into master Dec 5, 2023
2 checks passed
@wbobeirne wbobeirne deleted the wo/json-string-responses branch December 14, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"View it on mempool.space" has quotes in url and is invalid
2 participants