Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart federation setup #351

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Restart federation setup #351

merged 4 commits into from
Jan 23, 2024

Conversation

okjodom
Copy link
Collaborator

@okjodom okjodom commented Jan 18, 2024

Add UX for restarting federation setup. These need design review as the UX spec doesn't include restart experience

Validations

  • Lead guardian can initiate setup restart at SetConfiguration, ConnectGuardians, RunDKG or VerifyGuardians pages
  • Any follower guardian can initiate setup restart at the same pages
  • All guardians get notified of restart intent, and have to restart before proceeding

image
image

close #253

@okjodom okjodom requested review from a team as code owners January 18, 2024 06:36
@okjodom
Copy link
Collaborator Author

okjodom commented Jan 18, 2024

@Kodylow , @wbobeirne do test out this restart setup PR when you can. Did we have specific designs for restart UX?

@Kodylow
Copy link
Member

Kodylow commented Jan 19, 2024

The error message makes it seem like it's optional whether you should restart as well if there's another guardian who restarted. Like the restart isn't a "request" it's a "you are going to restart because another guardian restarted".
Should be more like "One of the guardians restarted the setup process".

Alternatively we could have it so only the setup leader can restart and then the message is "The Setup Leader Restarted the Ceremony". Think that would be better.

Then after I did a restart and tried again the followers all hung on this screen (shouldn't show restart here), until I refreshed. The setup leader stayed stuck here:

image

But all the followers would show this:

image

then be back on that 100% screen if you hit Approve again. And all the guardians would just stay hanging there.

@Kodylow
Copy link
Member

Kodylow commented Jan 19, 2024

@wbobeirne made some updates here with jodom:

Making it so only setup leader can initiate a restart. Then it has a confirm modal for are you sure you want to restart. Then folowers get notified the setup leader restarted the process and dump back to the first setup page.

Makes it way easier to avoid the whole setup leader vs folllower ordering bug. going to get some design feedback on it but after these changes and some testing it'll be good to go.

Copy link
Collaborator

@EthnTuttle EthnTuttle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At @Kodylow's behest.

@EthnTuttle EthnTuttle merged commit 6afbdee into fedimint:master Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can restart fedimint setup
3 participants