feat: pass in query param for role #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbobeirne
previously requested changes
Feb 13, 2024
Kodylow
force-pushed
the
query-params
branch
from
7738dc5
to
e18e894
Compare
okjodom
reviewed
Feb 19, 2024
okjodom
reviewed
Feb 19, 2024
Kodylow
force-pushed
the
query-params
branch
from
e4e9b29
to
f44de3d
Compare
|
Lgtm. I'll test in a bit. |
Kodylow
force-pushed
the
query-params
branch
from
f44de3d
to
3e2fb73
Compare
|
squashed |
okjodom
reviewed
Feb 20, 2024
| const roleQueryParam = getQueryParam('role')?.toLowerCase(); | ||
| if ( | ||
| roleQueryParam && | ||
| progress === SetupProgress.Start && |
There was a problem hiding this comment.
- line 93 is now redundant
- forcing
roleQueryParamto lower case is a bug becausehttp://localhost:3000/?role=Hostnever matches the include check oras GuardianRoletype coercion later
okjodom
reviewed
Feb 20, 2024
| @@ -94,6 +112,7 @@ export const FederationSetup: React.FC = () => { | |||
| title = t('setup.progress.tos.title'); | |||
| content = <TermsOfService next={() => setNeedsTosAgreement(false)} />; | |||
| } else { | |||
| // Removed the roleQueryParam handling from here as it's moved to useEffect | |||
There was a problem hiding this comment.
we can delete the comment
|
@Kodylow when I was testing this, I found some bugs (tagged) but I actually took a step back wondering if we actually need to skip the first page because of query param. Might it be better to pre-select the role from the value of query param, but let the guardian click next to proceed? Here is a cherry pick from validating the issue 9a9503d |
|
I agree that's better, then people acknowledge their role too. will update. |
Kodylow
force-pushed
the
query-params
branch
from
3e2fb73
to
441c9b8
Compare
|
Updated, made it way simpler too just a single useeffect in RoleSelector. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets you pass in
roleas a query param so we can skip the first setup page, we've found it a hiccup when doing setups for fedi