Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: finality_delay = block_confs - 1 #380

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

Kodylow
Copy link
Member

@Kodylow Kodylow commented Feb 21, 2024

fixes: #379

@Kodylow Kodylow requested a review from a team as a code owner February 21, 2024 20:56
@Kodylow Kodylow self-assigned this Feb 21, 2024
@justinmoon
Copy link
Contributor

What happens if a user enters 0 into the "block confirmations" field?

@Kodylow
Copy link
Member Author

Kodylow commented Feb 21, 2024

there's a min check in the form element:

<NumberFormControl
                labelText={t('set-config.block-confirmations')}
                helperText={t('set-config.block-confirmations-help')}
                warningText={t('set-config.block-confirmations-warning')}
                recommendedMin={6}
                min={1}
                max={200}
                value={blockConfirmations}
                onChange={(value) => {
                  setBlockConfirmations(value);
                }}
              />
              ```

@Kodylow
Copy link
Member Author

Kodylow commented Feb 21, 2024

image

@okjodom okjodom merged commit aa5c8a9 into fedimint:master Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Off-by-1 with finality_delay
3 participants