feat: add password visibility toggle #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nit: could we use an eye symbol instead of text? |
💯 . Avoids the need to translate the toggle button |
okjodom
reviewed
May 6, 2024
isaacknjama
force-pushed
the
gateway-password-toggle
branch
from
64123cb
to
c5e85e8
Compare
Kodylow
previously approved these changes
May 6, 2024
isaacknjama
force-pushed
the
gateway-password-toggle
branch
from
c5e85e8
to
bb0360b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #419
Visibility.toggle.webm
Using eye Icon instead of text:
visibility.eye.icon.webm