New meta manager

[Kodylow]

Made a bunch of updates and changes, think this works really well needs some testing though and I'm cleaning up the translations

Summary by CodeRabbit

• New Features

  • Introduced the MetaManager component for managing and editing metadata.
  • Added the ViewConsensusMeta component to display consensus metadata.
  • Added the ProposedMetas component for managing proposed meta edits.
  • Introduced the FederationConfigCard component for managing federation configurations.

• Enhancements

  • Improved EditMetaField component with new prop types and additional functionality.
  • Updated language translations with new labels and buttons for meta management and federation configuration.

• Bug Fixes

  • Fixed translation keys and labels to improve UI consistency and clarity.

[coderabbitai]

Walkthrough

Walkthrough

The recent updates enhance metadata management and federation configuration in the guardian-ui application. New components like MetaManager, ViewConsensusMeta, ProposedMetas, and FederationConfigCard were introduced. These changes aim to improve how users interact with metadata, propose edits, view consensus metadata, and manage federation configurations. Additionally, utility functions for metadata conversion were added in the utils package, and the en.json file was updated with new UI translations.

Changes

Files	Change Summary
MetaManager.tsx ViewConsensusMeta.tsx	Introduced MetaManager and ViewConsensusMeta components for metadata management and display. Added constants, utility functions, and polling functionality.
ProposedMetas.tsx EditMetaField.tsx	Added ProposedMetas component for managing proposed meta edits with voting features. Updated EditMetaField to use MetaFields type and added an optional prop for derived meta fields.
FederationConfigCard.tsx SetConfiguration.tsx	Introduced FederationConfigCard for managing federation configuration. SetConfiguration underwent structural changes and import reorganization.
en.json packages/utils/src/meta.ts	Updated en.json with new UI translations related to federation config and metadata. Introduced utility functions for metadata conversion in meta.ts.

Tip

New Features and Improvements

Review Settings

Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments.

AST-based Instructions

CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation.

Community-driven AST-based Rules

We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information.

New Static Analysis Tools

We are continually expanding our support for static analysis tools. We have added support for biome, hadolint, and ast-grep. Update the settings in your .coderabbit.yaml file or head over to the settings page to enable or disable the tools you want to use.

Tone Settings

Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:

• Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!"
• Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!"
• Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!"

Revamped Settings Page

We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to .coderabbit.yaml will be reflected in the settings page, and vice versa.

Miscellaneous

• Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the enable_free_tier setting.
• Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (local) or the organization (global) level using the knowledge_base setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations.
• High-level summary placement: You can now customize the location of the high-level summary in the PR description using the high_level_summary_placeholder setting (default @coderabbitai summary).
• Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the request_changes_workflow setting.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 134cfe7 and 4569966.

Files selected for processing (1)

• apps/guardian-ui/src/components/SetConfiguration.tsx (1 hunks)

Additional Context Used

Biome (7)

apps/guardian-ui/src/components/SetConfiguration.tsx (7)

348-348: Template literals are preferred over string concatenation.

---

47-47: Shouldn't redeclare 'NetworkIndicator'. Consider to delete it or rename it.

---

1-1: The default import is only used as a type.

---

23-29: Some named imports are only used as types.

---

188-188: Use Number.parseInt instead of the equivalent global.

---

215-215: Use Number.parseInt instead of the equivalent global.

---

217-217: Avoid the use of spread (...) syntax on accumulators.

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

Outside diff range and nitpick comments (3)

apps/guardian-ui/src/components/meta/ViewConsensusMeta.tsx (1)

1-109: The new ViewConsensusMeta component is well-structured and handles real-time data fetching effectively. Consider adding more detailed comments to improve maintainability.

apps/guardian-ui/src/components/FederationConfigCard.tsx (1)

1-107: The new FederationConfigCard component is robust and integrates well with the system's architecture. Ensure all dependencies are correctly listed in hooks to avoid potential bugs.

apps/guardian-ui/src/components/meta/EditMetaField.tsx (1)

Line range hint 1-86: The new EditMetaField component effectively manages meta field editing. Use more stable keys for list rendering to enhance performance and avoid re-rendering issues.

[coderabbitai]

Actionable comments posted: 6

Outside diff range and nitpick comments (1)

apps/guardian-ui/src/components/meta/EditMetaField.tsx (1)

89-89: Use a more descriptive element than an invisible Box for spacing when protectDerivedMeta is true.

Consider using a Spacer component or similar for better readability and maintainability.

[coderabbitai]

Actionable comments posted: 4

[coderabbitai]

Actionable comments posted: 4

[coderabbitai]

Actionable comments posted: 3

Outside diff range and nitpick comments (1)

apps/guardian-ui/src/components/FederationConfigCard.tsx (1)

1-19: Consider sorting import statements to improve readability and maintainability.

[elsirion]

Concept ACK, I think we can just try this out and fix minor problems when we encounter them.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (5)

apps/guardian-ui/src/components/SetConfiguration.tsx (5)

Line range hint 47-47: Remove or rename the duplicate import of NetworkIndicator.

- import { NetworkIndicator } from '@fedimint/ui';

---

Line range hint 1-1: Optimize imports by removing unused ones and using type imports where applicable.

- import React, { useEffect, useState } from 'react';
+ import React from 'react';
+ import type { useEffect, useState } from 'react';
- import {
-   BitcoinRpc,
-   ConfigGenParams,
-   ModuleKind,
-   Network,
- } from '@fedimint/types';
+ import type {
+   BitcoinRpc,
+   ConfigGenParams,
+   ModuleKind,
+   Network,
+ } from '@fedimint/types';

Also applies to: 23-29

---

Line range hint 188-188: Use Number.parseInt for parsing integers.

- const finalityDelay = parseInt(blockConfirmations, 10) - 1;
+ const finalityDelay = Number.parseInt(blockConfirmations, 10) - 1;
- numPeers: parseInt(numPeers, 10),
+ numPeers: Number.parseInt(numPeers, 10),

Also applies to: 215-215

---

Line range hint 217-217: Avoid using spread syntax on accumulators in reduce functions.

- meta: metaFields.reduce((acc, [key, val]) => ({ ...acc, [key]: val }), {}),
+ meta: Object.fromEntries(metaFields),

---

Line range hint 348-348: Prefer template literals over string concatenation.

- <span>{t('set-config.bitcoin-settings') + ': '}</span>
+ <span>{`${t('set-config.bitcoin-settings')}: `}</span>

[Kodylow]

Kk I was going to simultaneously remove the meta in config options with this but if we just land it rn we'll need to keep that in until we have client support for meta module