-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: larger charset passwords #443
Conversation
WalkthroughWalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Function: generatePassword
participant CharSet
User ->> Function: Call generatePassword()
Function ->> CharSet: Load new charSet with uppercases + specials
CharSet -->> Function: Randomly generate password
Function -->> User: Return complex password
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (2)
Tip Early access features: disabledWe are currently testing the following features in early access:
Note:
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@@ -24,7 +24,8 @@ export const generatePassword = () => { | |||
}; | |||
|
|||
const passwordLength = 16; | |||
const charSet = 'abcdefghjkmnpqrstuvwxyz0123456789'; | |||
const charSet = | |||
'abcdefghjkmnpqrstuvwxyzABCDEFGHJKLMNPQRSTUVWXYZ0123456789!@#$%^&*()'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
he okayed it last time, was 80 bit entropy when optional but since we're requiring now we should do the increased charset
adds caps and special characters for password generation, entropy increase from 82.7184 -> 98.72 bits , since we're making the generatePassword function the required firststep we should force best practices.
Summary by CodeRabbit