fix: move basic settings down for more reasonable password setting #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughWalkthroughThe updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SetConfiguration
participant BasicSettingsForm
participant FederationSettingsForm
participant ConfirmPasswordModal
User->>SetConfiguration: Initiate configuration
SetConfiguration->>BasicSettingsForm: Render basic settings form
BasicSettingsForm-->>SetConfiguration: Return basic settings data
SetConfiguration->>FederationSettingsForm: Render federation settings form
FederationSettingsForm-->>SetConfiguration: Return federation settings data
SetConfiguration->>ConfirmPasswordModal: Show password confirmation
ConfirmPasswordModal-->>SetConfiguration: Confirm password backup status
SetConfiguration->>User: Display configuration summary
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
elsirion
reviewed
Jul 30, 2024
Comment on lines
-275
to
-284
| <Checkbox | ||
| isRequired | ||
| spacing='10px' | ||
| alignSelf='flex-start' | ||
| onChange={(e) => setPasswordCheck(e.target.checked)} | ||
| > | ||
| <Text color={theme.colors.yellow[500]}> | ||
| {t('set-config.admin-password-backup')} | ||
| </Text> | ||
| </Checkbox> |
There was a problem hiding this comment.
Maybe instead of checking that checkbox we could require the user to surprise re-enter the password at the end? Or at least prompt that they need to back it up?
There was a problem hiding this comment.
I've got the confirmPassword to move to the next screen, I could add it to the verification step before they continue to the dashboard?
Kodylow
force-pushed
the
password-section
branch
from
e180e11
to
2ba4b89
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Comment on lines
233
to
234
| "password-warning": "Debes hacer una copia de seguridad de tu contraseña y guardarla en un lugar seguro. Esta contraseña es necesaria para acceder a tu tablero de guardianes. ¡No puedes recuperarla si la pierdes!", | ||
| "password-warning-title": "¡Haz una copia de seguridad de tu contraseña!" |
There was a problem hiding this comment.
Correct the language to Italian.
The added key-value pairs are in Spanish, not Italian. Ensure the translations are in the correct language.
- "password-warning": "Debes hacer una copia de seguridad de tu contraseña y guardarla en un lugar seguro. Esta contraseña es necesaria para acceder a tu tablero de guardianes. ¡No puedes recuperarla si la pierdes!",
- "password-warning-title": "¡Haz una copia de seguridad de tu contraseña!"
+ "password-warning": "Devi fare una copia di backup della tua password e conservarla in un luogo sicuro. Questa password è necessaria per accedere alla tua dashboard dei guardiani. Non puoi recuperarla se la perdi!",
+ "password-warning-title": "Fai una copia di backup della tua password!"Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "password-warning": "Debes hacer una copia de seguridad de tu contraseña y guardarla en un lugar seguro. Esta contraseña es necesaria para acceder a tu tablero de guardianes. ¡No puedes recuperarla si la pierdes!", | |
| "password-warning-title": "¡Haz una copia de seguridad de tu contraseña!" | |
| "password-warning": "Devi fare una copia di backup della tua password e conservarla in un luogo sicuro. Questa password è necessaria per accedere alla tua dashboard dei guardiani. Non puoi recuperarla se la perdi!", | |
| "password-warning-title": "Fai una copia di backup della tua password!" |
dpc
approved these changes
Aug 5, 2024
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves password and basic settings down as the last thing you do before password confirmation and adds the checkbox in confirm password with a warning info
Summary by CodeRabbit
New Features
FederationSettingsFormto conditionally display inputs based on user role.ConfirmPasswordModal.Bug Fixes
Refactor