Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable back while at connectGuardians #465

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

Kodylow
Copy link
Member

@Kodylow Kodylow commented Aug 5, 2024

You have to restart the whole ceremony after connecting a Guardian, so disables back button for host and followers once they get to the point where they've moved their state along for ConnectGuardians. The host can still restart the full ceremony.

Summary by CodeRabbit

  • New Features
    • Updated the setup process to restrict navigation by disabling the ability to go back during the FederationSetup phase, enhancing control over the user flow.

@Kodylow Kodylow requested a review from a team as a code owner August 5, 2024 16:50
Copy link
Contributor

coderabbitai bot commented Aug 5, 2024

Walkthrough

Walkthrough

The recent changes to the FederationSetup component in the FederationSetup.tsx file modify the navigation logic by setting the canGoBack variable to false. This adjustment disables the user's ability to return to the previous step in the setup process, impacting the overall user experience by restricting navigation options at this stage.

Changes

File Path Change Summary
apps/guardian-ui/src/setup/FederationSetup.tsx Updated canGoBack logic to false, disabling back navigation in setup.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FederationSetup
    User->>FederationSetup: Attempt to go back
    FederationSetup-->>User: Navigation blocked
Loading

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d240b04 and 69b3b2c.

Files selected for processing (1)
  • apps/guardian-ui/src/setup/FederationSetup.tsx (1 hunks)
Additional comments not posted (1)
apps/guardian-ui/src/setup/FederationSetup.tsx (1)

145-145: LGTM! Disabling back navigation at ConnectGuardians stage.

The change to set canGoBack to false during the ConnectGuardians stage is appropriate to prevent disruption in the setup process.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Kodylow Kodylow merged commit 5050161 into fedimint:master Aug 5, 2024
1 check passed
@Kodylow Kodylow deleted the disable-back branch August 5, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants