-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup app state #494
Conversation
WalkthroughWalkthroughThe changes enhance authentication handling in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant Gateway
User->>App: Initiates login
App->>Gateway: Checks credentials
Gateway-->>App: Returns authentication status
App-->>User: Displays loading state
User-->>App: Receives feedback
sequenceDiagram
participant User
participant Login
User->>Login: Submits login form
Login->>Loading: Set loading to true
Login->>Gateway: Authenticate user
Gateway-->>Login: Authentication result
Login->>Loading: Set loading to false
Login-->>User: Display result
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
@@ -21,7 +21,7 @@ export const UNIT_OPTIONS = ['msats', 'sats', 'btc'] as const; | |||
export type Unit = (typeof UNIT_OPTIONS)[number]; | |||
|
|||
export const App = React.memo(function Admin(): JSX.Element { | |||
const gateway = useMemo(() => new GatewayApi(), []); | |||
const gateway = useRef(() => new GatewayApi()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewer: useRef
better indicates that gateway
doesn't change, so we can safely remove it as a dep from the useEffect
s below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary by CodeRabbit
New Features
Bug Fixes
Documentation