-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: require 5 blocks for mainnet #502
Conversation
WalkthroughWalkthroughThe recent updates enhance the BitcoinSettingsForm by introducing dynamic helper text and adjustable minimum values for a form control based on the selected network. Specifically, the logic now distinguishes between Bitcoin and other networks, improving user guidance and experience. Additionally, a new localization entry clarifies the requirement for extra confirmations when operating on the Mainnet. Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
07adf74
to
74d4c69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Help text could be better, but requiring 5 or 6 confirmations seems reasonable (although I'll surely work around it at some point because I'm reckless 🤣)
Unsafe to run with less on mainnet, disables the option to go under 5
Summary by CodeRabbit
New Features
Improvements