Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Python virtualenv in development #1748

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

anshikavashistha
Copy link

This is with reference to the issue

@anshikavashistha anshikavashistha requested a review from a team as a code owner March 26, 2024 09:04
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/ad6469d08570488aae8a7b296922319d

fi-tox-mypy FAILURE in 5m 17s
✔️ fi-tox-lint SUCCESS in 5m 13s
✔️ fi-tox-format SUCCESS in 4m 56s
fi-tox-python38 FAILURE in 6m 49s
fi-tox-python39 FAILURE in 6m 12s
fi-tox-python310 FAILURE in 6m 52s
fi-tox-python311 FAILURE in 6m 14s
fi-tox-docs FAILURE in 6m 32s
✔️ fi-tox-bandit SUCCESS in 5m 02s
fi-tox-diff-cover FAILURE in 7m 05s

@Zlopez Zlopez linked an issue Mar 26, 2024 that may be closed by this pull request
@Zlopez
Copy link
Contributor

Zlopez commented Mar 26, 2024

@anshikavashistha Plenty of tests started failing after the change, could you look into that?

@anshikavashistha
Copy link
Author

@Zlopez I am also trying to figure it out. Meanwhile you could suggest me the required modifications to be done.
I am currently to running all these tests which are getting failed.

@Zlopez
Copy link
Contributor

Zlopez commented Mar 27, 2024

If you look at the failing tests the issue is obvious anitya_version doesn't have get_distribution method.

@anshikavashistha
Copy link
Author

@Zlopez How should I solved the failure if anitya_version doesn't have get_distribution method?

@Zlopez
Copy link
Contributor

Zlopez commented Mar 27, 2024

It's just the string that contains the same information as pkg_resources.get_distribution.

@anshikavashistha
Copy link
Author

@Zlopez I agree with you. Yes that's right pkg_resources has get_ditsribution method but anitya_version don't have.
What should be the alternative to this method for anitya_version?

@anshikavashistha
Copy link
Author

@Zlopez May be this will work version = version_str ?

@Zlopez
Copy link
Contributor

Zlopez commented Mar 28, 2024

anitya_version should be the same as what is returned by pkg_resources.get_distribution('anitya').version. But it needs to be tested first. I'm not sure if we already used poetry at the time this ticket was open. Just try it and see.

@anshikavashistha
Copy link
Author

Sure @Zlopez I try it and tests it

Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/239eaa5e45c24bde846c8f5f74a0ba8c

✔️ fi-tox-mypy SUCCESS in 5m 22s
✔️ fi-tox-lint SUCCESS in 4m 56s
fi-tox-format FAILURE in 5m 07s
✔️ fi-tox-python38 SUCCESS in 8m 59s
✔️ fi-tox-python39 SUCCESS in 9m 24s
✔️ fi-tox-python310 SUCCESS in 9m 01s
✔️ fi-tox-python311 SUCCESS in 9m 01s
✔️ fi-tox-docs SUCCESS in 6m 28s
✔️ fi-tox-bandit SUCCESS in 5m 06s
✔️ fi-tox-diff-cover SUCCESS in 9m 07s

Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/671d0fe790b74fb0b4127330dfba4a92

✔️ fi-tox-mypy SUCCESS in 5m 07s
✔️ fi-tox-lint SUCCESS in 4m 29s
fi-tox-format FAILURE in 4m 24s
✔️ fi-tox-python38 SUCCESS in 8m 25s
✔️ fi-tox-python39 SUCCESS in 8m 47s
✔️ fi-tox-python310 SUCCESS in 9m 23s
✔️ fi-tox-python311 SUCCESS in 8m 23s
✔️ fi-tox-docs SUCCESS in 6m 22s
✔️ fi-tox-bandit SUCCESS in 5m 01s
✔️ fi-tox-diff-cover SUCCESS in 9m 23s

@anshikavashistha
Copy link
Author

@Zlopez I have tried to test and run anitya_version .Here some of the tests are successful but one of them tox-format is not running.

@Zlopez
Copy link
Contributor

Zlopez commented Apr 2, 2024

And what was the output, did it returned the same value as pkg_resources.get_distribution('anitya').version?

The format should be easily fixed by running black on the code. Look at the documentation.

@anshikavashistha
Copy link
Author

@Zlopez Sure I will try to format the code as mentioned in the documentation and then try to run

Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/a9b1a722b7c246d7b3612a7d87a4818b

✔️ fi-tox-mypy SUCCESS in 5m 08s
✔️ fi-tox-lint SUCCESS in 5m 05s
fi-tox-format FAILURE in 4m 45s
✔️ fi-tox-python38 SUCCESS in 8m 58s
✔️ fi-tox-python39 SUCCESS in 9m 20s
✔️ fi-tox-python310 SUCCESS in 9m 16s
✔️ fi-tox-python311 SUCCESS in 8m 56s
✔️ fi-tox-docs SUCCESS in 6m 35s
✔️ fi-tox-bandit SUCCESS in 5m 09s
✔️ fi-tox-diff-cover SUCCESS in 10m 05s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the python virtualenv for development
2 participants