Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates cannot be edited in staging due to BDR #1318

Open
bowlofeggs opened this issue Mar 2, 2017 · 3 comments
Open

Updates cannot be edited in staging due to BDR #1318

bowlofeggs opened this issue Mar 2, 2017 · 3 comments
Labels
Crash Issues related to an unhandled crash High priority These issues are higher priority than normal Migration Issues or pull requests that involve a database migration
Milestone

Comments

@bowlofeggs
Copy link
Contributor

BDR doesn't allow writes to tables that don't have primary keys. I got an error message from staging when trying to edit an update:

Cannot run UPDATE or DELETE on table update_bug_table because it does not have a PRIMARY KEY.

This table is defined in a block of association tables, and none of them seem to have primary keys.

We will need to fix this before BDR is deployed to production.

@bowlofeggs bowlofeggs added Crash Issues related to an unhandled crash High priority These issues are higher priority than normal Migration Issues or pull requests that involve a database migration labels Mar 2, 2017
@bowlofeggs
Copy link
Contributor Author

bowlofeggs commented Apr 19, 2017

Today I found that I also cannot log in to staging Bodhi, also due to BDR from a different block of association tables:

https://github.com/fedora-infra/bodhi/blob/2.5.0/bodhi/server/models.py#L2242-L2252

Cannot run UPDATE or DELETE on table user_group_table because it does not have a PRIMARY KEY.

So we'll need to fix those as well.

@bowlofeggs bowlofeggs added this to the 2.7.0 milestone Apr 25, 2017
@bowlofeggs bowlofeggs added Critical We can't go on living in this sqalor, drop everything and fix it! and removed High priority These issues are higher priority than normal labels Apr 25, 2017
@bowlofeggs
Copy link
Contributor Author

This prevents the staging server from being useful for testing because I cannot log in to staging. Thus, I am raising it to critical priority and setting a goal to include it in bodhi 2.7.0.

@bowlofeggs
Copy link
Contributor Author

@puiterwijk sent me this link, which might be useful for solving the duplicates: https://wiki.postgresql.org/wiki/Deleting_duplicates

@bowlofeggs bowlofeggs added High priority These issues are higher priority than normal and removed Critical We can't go on living in this sqalor, drop everything and fix it! labels Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crash Issues related to an unhandled crash High priority These issues are higher priority than normal Migration Issues or pull requests that involve a database migration
Projects
None yet
1 participant