Compare enum values instead of descriptions. #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were multiple places in the template code that were comparing Enum human readable descriptions instead of the Enum values. The descriptions are meant to be human readable and are subject to change, so this code was at risk of breaking if someone changes those descriptions in the future. Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
bowlofeggs
added
HTML
pypingou
approved these changes
Feb 18, 2019
|
This patch is planned for inclusion in the upcoming 4.0.0 release: #3221 |
|
Bodhi 4.0.0 beta is built and deployed to staging: https://copr.fedorainfracloud.org/coprs/bowlofeggs/bodhi-pre-release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were multiple places in the template code that were
comparing Enum human readable descriptions instead of the Enum
values. The descriptions are meant to be human readable and are
subject to change, so this code was at risk of breaking if someone
changes those descriptions in the future.
Signed-off-by: Randy Barlow randy@electronsweatshop.com