Replace the call to hawkey with a call to DNF in repo sanity check #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puiterwijk
added
Critical
bowlofeggs
suggested changes
Apr 30, 2019
bowlofeggs
reviewed
Apr 30, 2019
puiterwijk
force-pushed
the
dnf_hawkey
branch
2 times, most recently
from
dd253d0
to
5b8f4f3
Compare
|
The latest change adds the one missing line of diff cover, and fixes some flake8 errors. |
libdnf/hawkey silently dropped the API we were using to do repo sanity checks. So instead, let's just shell out to DNF and make it their problem. Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
|
Had forgotten to run flake8 over the test :). |
sebwoj
suggested changes
May 1, 2019
| dnf_args (list): A list of arguments after DNF is set up to use the repo under test. | ||
| Example would be ["search", "kernel"] or ["module", "list"]. | ||
| Raises: | ||
| Exception: If the repodata is not valid or does not exist. |
There was a problem hiding this comment.
Actually, function is returning CalledProcessError
There was a problem hiding this comment.
For now that's the only option, yes. But I have plans to add more checks, which might return other exceptions.
And the current docblock is technically correct:
>>> issubclass(subprocess.CalledProcessError, Exception)
True
|
This patch is planned for inclusion in the upcoming 4.0.0 release: #3221 |
|
Bodhi 4.0.0 beta is built and deployed to staging: https://copr.fedorainfracloud.org/coprs/bowlofeggs/bodhi-pre-release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libdnf/hawkey silently dropped the API we were using to do repo sanity checks.
So instead, let's just shell out to DNF and make it their problem.
Signed-off-by: Patrick Uiterwijk patrick@puiterwijk.org