Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zstd compression #96

Closed
dralley opened this issue Feb 1, 2023 · 4 comments · Fixed by #98
Closed

Support zstd compression #96

dralley opened this issue Feb 1, 2023 · 4 comments · Fixed by #98
Assignees

Comments

@dralley
Copy link
Contributor

dralley commented Feb 1, 2023

createrepo_c is adding support for zstd-compressed metadata, which has a lot of benefits. I intend to push for this to be used by Fedora eventually.

(I'll submit a PR for this later, it should be very easy to add)

dralley added a commit to dralley/mdapi that referenced this issue Feb 1, 2023
dralley added a commit to dralley/mdapi that referenced this issue Feb 1, 2023
dralley added a commit to dralley/mdapi that referenced this issue Feb 15, 2023
dralley added a commit to dralley/mdapi that referenced this issue Feb 17, 2023
dralley added a commit to dralley/mdapi that referenced this issue Feb 17, 2023
dralley added a commit to dralley/mdapi that referenced this issue Feb 24, 2023
@gridhead
Copy link
Member

Assigned this ticket to you for now.

Could you please let me know about the benefits that you mentioned, that would come if the zstd compression is implemented?

@dralley
Copy link
Contributor Author

dralley commented Feb 28, 2023

Well the benefits to mdapi, assuming zstd-compressed-metadata were adopted by Fedora, would just be that mdapi wouldn't immediately break if/when they turn it on.

In terms of being adopted by Fedora - DNF already supports it, it's just a matter of producing the metadata. You can read rpm-software-management/createrepo_c#345 but the TL;DR version is faster decompression and smaller metadata file sizes.

@gridhead
Copy link
Member

Understood.

Would you want me to wait until rpm-software-management/createrepo_c#345 is merged before we merge the PR associated with this issue ticket?

@dralley
Copy link
Contributor Author

dralley commented Feb 28, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants