Skip to content

Conversation

net1957
Copy link

@net1957 net1957 commented Jul 31, 2017

after your request on PR #4

@maxmeyer, please review

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.629% when pulling de32e55 on net1957:rubocop into a793114 on fedux-org:master.

Copy link
Member

@maxmeyer maxmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot.

@maxmeyer maxmeyer merged commit e725c63 into feduxorg:master Jul 31, 2017
@maxmeyer
Copy link
Member

maxmeyer commented Jul 31, 2017

@net1957 I released 3.0.0 to rubygems yesterday. Are your issues fixed? I'm interested in how you use the gem. Do you have a rails app distributing proxy.pac files?

@net1957
Copy link
Author

net1957 commented Aug 1, 2017

Thanks for the release.

I use it in a rails application to check the result of a proxy script.
the corporate environment use many proxy. It help us to verify if it is working properly.

image

@net1957 net1957 deleted the rubocop branch August 1, 2017 19:15
@maxmeyer
Copy link
Member

maxmeyer commented Aug 3, 2017

That's great. I was thinking about building something similar. Is this rails app Open Source?

@net1957
Copy link
Author

net1957 commented Aug 3, 2017

at this time it's not open source, but it should not be to difficult to do it.

@maxmeyer
Copy link
Member

maxmeyer commented Aug 3, 2017

If this is not that much work why not releasing it to the public? 😄

@net1957
Copy link
Author

net1957 commented Aug 16, 2017

Hello!

it's done on https://github.com/net1957/ProxyCheck

@maxmeyer, I'm awaiting your feedback.
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants