This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
RAINCATCH-1262 - server side config improvements #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JameelB
approved these changes
Sep 18, 2017
| }, | ||
| }, | ||
| // Keycloak configuration. Uncomment to enable keycloak integration | ||
| // "keycloak": { |
There was a problem hiding this comment.
Do you think it would be best to fill in the details here? Otherwise we can add a note that they need to fill these in themselves?
"realm": "raincatcher",
"bearer-only": true,
"auth-server-url": "http://localhost:8080/auth",
"ssl-required": "external",
"resource": "raincatcher-cloud",
"use-resource-role-mappings": true
There was a problem hiding this comment.
hmm.. I think we will cover that in documentation. Missing details means some action. If we provide some values some people may take them for granted and then file bugs that stuff do not work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Application configuration should be centralized and easy to manage using environment variables.
Description
Improve server side configuration to not relay on the environment variables inside various files in the code. To do that configuration cannot be json anymore.
We need to have ability to choose from environment variables or default values.
That's why I have moved configuration to js files.
JS files will allow us to:
Progress