This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
RAINCATCH-1190 - Extract security interface #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtrocki
requested review from
austincunningham,
JameelB,
paolobueno and
witmicko
as code owners
wtrocki
commented
Aug 24, 2017
|
|
||
| // Use keycloak middleware & define applications logout route | ||
| app.use(keycloak.middleware({logout: '/logout'})); | ||
| export class KeycloakSecurity implements EndpointSecurity { |
There was a problem hiding this comment.
I still think that despite this being really simple we should have it as separate module.
JameelB
reviewed
Aug 24, 2017
| // Create a session store | ||
| const memoryStore = new session.MemoryStore(); | ||
| this.keycloak = new Keycloak({ store: memoryStore }, config.keycloakConfig); | ||
| } |
There was a problem hiding this comment.
also re-add the app.use(keycloak.middleware({logout: '/logout'})); to use keycloak middleware and define the logout route
cloud/auth/src/EndpointSecurity.ts
Outdated
| * @param redirect - location to redirect after successful authentication | ||
| * @param loginError - location to redirect after failed authentication | ||
| */ | ||
| authenticate(redirect: string, loginError: string): express.Handler; |
There was a problem hiding this comment.
would it be possible to remove this from the interface if this only refers to passport?
wtrocki
force-pushed
the
RAINCATCH-1190
branch
from
1dec531
to
b9bb465
Compare
|
@JameelB Really good point about dropping this method. |
|
Changes Unknown when pulling 79e194d on wtrocki:RAINCATCH-1190 into ** on feedhenry-raincatcher:master**. |
1 similar comment
|
Changes Unknown when pulling 79e194d on wtrocki:RAINCATCH-1190 into ** on feedhenry-raincatcher:master**. |
paolobueno
approved these changes
Aug 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.