This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
log fhconfig #130
Closed
log fhconfig #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will bump the component's version once the PR gets approved. |
| @@ -102,6 +102,8 @@ function loadConfig(cb) { | |||
| // read our config file | |||
| var configFile = process.env.conf_file || args._[0]; | |||
|
|
|||
| console.log(fhconfig); | |||
There was a problem hiding this comment.
Should it be merged?
| @@ -102,6 +102,8 @@ function loadConfig(cb) { | |||
| // read our config file | |||
| var configFile = process.env.conf_file || args._[0]; | |||
|
|
|||
| console.log(fhconfig); | |||
|
|
|||
| fhconfig.init(configFile, requiredvalidation, function(err) { | |||
There was a problem hiding this comment.
Shows that @matskiv has reason the name of the function reload was changed in the 2.0.0 of the dep fh-config. Also, shows that for we move forward with it instead of you use the init here we could use the reloadRawConfig.
|
Hi @odra
|
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link(s)
https://issues.jboss.org/browse/RHMAP-21672
What
fh-mbaas is failing to retrieve the cloud app's connection string.
Why
Issue is caused by incorrect usage of fh-config api.
How
It doesn't make much sense to use the reload method: https://github.com/feedhenry/fh-config/blob/master/lib/fhconfig.js#L108 when retrieving the connection string since we were using an empty array as its function argument.
Verification Steps
Checklist: