Add Support to Upsert/Insert Ignore on PDB #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
victorcmg
commented
Jun 22, 2023
victorcmg
commented
- Makes the implementation of DatabaseEngine optional, so it does not break compatibility with other library clients.
- Makes the implementation of DatabaseEngine optional, so it does not break compatibility with other library clients.
src/main/java/com/feedzai/commons/sql/abstraction/engine/DatabaseEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/DatabaseEngine.java
Outdated
Show resolved
Hide resolved
- Addresses comments: changes message in the default method implementation.
jmf-tls
approved these changes
Jun 22, 2023
diogo-anjos-fdz
approved these changes
Jun 22, 2023
victorcmg
pushed a commit
to victorcmg/pdb
that referenced
this pull request
Jul 3, 2023
This reverts commit d4f7c4e.
victorcmg-fdz
added a commit
to victorcmg-fdz/pdb
that referenced
this pull request
Aug 20, 2024
This reverts commit d4f7c4e.
diogo-anjos-fdz
pushed a commit
that referenced
this pull request
Aug 22, 2024
Recently, it was added a support for the upsert of entries in the pdb library. The feature added supported for entities to, when applicable, be able to be upserted or depending on the engine implementation, an insert ignore or even merge. The feature also enabled the upsert feature for batch processing, i.e. entries could now use the new upsert API. However, after its usage it was possible to conclude it decreased performance when client application used this new API. Giving the degrading performance and also the log messages some of the entities generated for not having the upsert statement available, it was decided to remove this feature entirely from the pdb code-base. --- * Revert "Removes error logging for UPSERT command when creating an entity (#407)" This reverts commit 94ba1a5. * Revert "Add Support to Upsert/Insert Ignore on PDB (#392)" This reverts commit 46f29b2. * Revert "Add Support to Upsert/Insert Ignore on PDB (#389)" This reverts commit 963cd30. * Revert "Add Support to Upsert/Insert Ignore on PDB (#388)" This reverts commit d4f7c4e. * Revert "Add Support to Upsert/Insert Ignore on PDB" This reverts commit d626297. * Revert "Add Support to Upsert/Insert Ignore on PDB" This reverts commit 1d32f7f. * Revert "Add Support to Upsert/Insert Ignore on PDB" This reverts commit 36a434c. * Revert "Add Support to Upsert/Insert Ignore on PDB" This reverts commit 1658965. * Revert "Add Support to Upsert/Insert Ignore on PDB" This reverts commit d2f153b. * Revert "Add Support to Upsert/Insert Ignore on PDB" This reverts commit 2f0d1ff * Revert "Add Support to Upsert/Insert Ignore on PDB" This reverts commit 348a22d * Revert "Add Support to Upsert/Insert Ignore on PDB" This reverts commit e100a51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.