Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganisation of feelpp repo #1734

Closed
4 of 8 tasks
prudhomm opened this issue Nov 22, 2021 · 0 comments · Fixed by #1810
Closed
4 of 8 tasks

Reorganisation of feelpp repo #1734

prudhomm opened this issue Nov 22, 2021 · 0 comments · Fixed by #1810
Assignees
@prudhomm @vincentchabannes
Labels
type:refactoring
Milestone
v110

Comments

@prudhomm
Copy link
Member

prudhomm commented Nov 22, 2021 •
edited
Loading

feelpp is organized in components:

  • feelpp

  • toolboxes

  • mor

  • python [pyfeelpp,pyfeelpp-toolboxes,pyfeelpp-mor]

  • examples

  • benchmarks
    More components may appear in the future

  • feelpp is built component-wise and component may depend on other components, eg toolboxes depend on feelpp, mor depends on toolboxes, python depends on feelpp, toolboxes and mor.

  • Each component should have a tests directory with a testsuite to be run. C++ based components may use boost.testsuite The python component should use pytest to define the testsuite

  • Example include quickstart and doc/manual codes

  • testsuite should be split between feelpp and mor

  •  feelpp crb/eim/pbdw headers should be moved to mor

  • toolboxes should be organized component wise

  • core toolbox should be created with modelcore and modelmesh

  • deb and docker packages should be created component wise

Some explanations are in the pdf file attached .
@prudhomm prudhomm added this to the v110 milestone Nov 22, 2021
prudhomm added a commit that referenced this issue Nov 23, 2021
@prudhomm
up #1734
a1d1df9 
mv mor example apps to examples
@prudhomm prudhomm mentioned this issue Dec 7, 2021
Closed
3 tasks
prudhomm added a commit that referenced this issue Mar 14, 2022
@prudhomm
move package and version cmake to toplevel #1734
ad4b0f9
prudhomm added a commit that referenced this issue Mar 14, 2022
@prudhomm
add extradist script to package git.cpp #1734
b973c90
prudhomm added a commit that referenced this issue Mar 14, 2022
@prudhomm
generate git.cpp #1734
5ea7354
prudhomm added a commit that referenced this issue Mar 14, 2022
@prudhomm
Reorganisation of feelpp repo #1734
60ab1e0 
- moved pyfeelpp* to python component
- adapted the CMakeLists.txt
prudhomm added a commit that referenced this issue Mar 14, 2022
@prudhomm
Reorganisation of feelpp repo #1734
9adf09b 
adapted the CMake files to the python component
prudhomm added a commit that referenced this issue Mar 14, 2022
@prudhomm
Reorganisation of feelpp repo #1734
62a65f0 
new presets
 -  feelpp-python
 - feelpp-python-dbg

removed pyfeelpp-all
prudhomm added a commit that referenced this issue Mar 14, 2022
@prudhomm
Reorganisation of feelpp repo #1734
2550fb8 
fix build process
update buildkite/docker
add python component in buildkite/docker
@prudhomm prudhomm linked a pull request Mar 14, 2022 that will close this issue
1734 reorganisation of feelpp repo #1810
Merged
5 tasks
@prudhomm prudhomm mentioned this issue Mar 14, 2022
Merged
5 tasks
prudhomm added a commit that referenced this issue Mar 14, 2022
@prudhomm
Reorganisation of feelpp repo #1734
e18ce9f 
fix component name use FEELPP_PYTHON
prudhomm added a commit that referenced this issue Mar 16, 2022
@prudhomm
use preset
de81c30 
 Reorganisation of feelpp repo #1734
prudhomm added a commit that referenced this issue Mar 18, 2022
@prudhomm
Reorganisation of feelpp repo #1734
9dc696e 
- enable ctest
- update packaging feelpp and its component: fix package name
- embed spdlog and taskflow as sumbodule to avoid fetching in deb buildong (forbidden)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prudhomm prudhomm

@vincentchabannes vincentchabannes

Labels
type:refactoring
Projects
Feel++
Status: Done
Milestone
v110
Development

Successfully merging a pull request may close this issue.

1734 reorganisation of feelpp repo feelpp/feelpp
2 participants
@prudhomm @vincentchabannes