Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/named arguments #1724

Merged
merged 79 commits into from
Nov 23, 2021
Merged

Feature/named arguments #1724

merged 79 commits into from
Nov 23, 2021

Conversation

vincentchabannes
Copy link
Member

@vincentchabannes vincentchabannes commented Nov 7, 2021 •
edited
Loading

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?
  • Have you successfully run the Feel++ testsuite with your changes locally?
  • Have you written Doxygen comments in your contribution ?
  • replace boost parameter by napp : fix compilation with boost 1.71
  • review includes of boost fusion (not patch with boost fusion vector from boost >=1.71)
  • replace deprecated boost/timer.hpp by in house Feel::Timer (by using std::chrono ...)
  • fix support gcc/g++ compiler
  • some others minor up :
    ** replace tabulate/table by Feel::table : not depend on english locale (fix for example with french locale)
    ** not use integrate on edges in pyfeelpp (fix some warning by review declartion of integrator::evaluate)
    ** fix memory leak in static condensation
    ** fix parameter space::distributeOnAllProc

@vincentchabannes
use na with loadMesh
2693494
@vincentchabannes
comment some include headers in crb
155083e
@vincentchabannes
up benchmarkgrepl-linear-elliptic
876326f
@vincentchabannes
work on feelcore
1e5a8fd
@vincentchabannes
work on feelcore
c333d70
@vincentchabannes
work on feelalg
49c6495
@vincentchabannes
work on feelalg
334ed43
@vincentchabannes
support boption, doption ... with non named arg (only a string)
6e5c322
@vincentchabannes
continue replacement of boost paramater
49d80d0
@vincentchabannes
continue replacement of boost paramater
c0c3c2e
@vincentchabannes
continue replacement of boost paramater
b25214d
@vincentchabannes
fix compilation
25c596a
@vincentchabannes
continue replacement of boost paramater
2a32d3f
@vincentchabannes
fix compilation
ec6bc60
@vincentchabannes
fix compilation
83d84af
@vincentchabannes
continue replacement of boost paramater
3c2e591
@vincentchabannes
fix compilation
a625715
@vincentchabannes
fix compilation
c0d7d76
@vincentchabannes
fix compilation
47145e1
@vincentchabannes
add napp as submodule
eb90e63
@vincentchabannes
try to fix boost fusion vector : only include in 2 headers (and use t…
2b68783 
…he patch if required)
@vincentchabannes
try to fix include of boost fusion
01e3a7c
@vincentchabannes
continue replacement of boost paramater
02e91aa
@vincentchabannes
fix warning all paths through this function will call itself [-Winfin…
d3100c3 
…ite-recursion] + remove integrate on (edges not implemented) : @prudhomm maybe cherry pick this one?
@vincentchabannes
fix warning misleading indentation
a3e44ea
@vincentchabannes
no python-mpi tests in waiting to understand python issue with export…
0584e05 
…er path + re-enable feelpp_qs tests
@vincentchabannes
fix default arg
81802a4
@vincentchabannes
replace boost parameter
50ddaf3
@vincentchabannes
fix compilation
66d8949
@vincentchabannes
fix named arg
cc527f5
@vincentchabannes
some fixes by using gcc in testsuite
5aad6ab
@vincentchabannes
some fixes when gcc compiler is used
d12f678
@vincentchabannes
fix toolboxes compilation with gcc
10be219
@vincentchabannes
fix compilation with gcc (seems a bug with gcc <=11 )
0ef7cc3
@vincentchabannes
refactoring pow with modern cpp + fix gcc eval
565c6a0
@vincentchabannes
some fixes in feelpp/mor with gcc
fc5a8d3
@vincentchabannes
Merge remote-tracking branch 'origin/develop' into feature/named_argu…
06dc9bc 
…ments
@vincentchabannes
not compile these hdg app (and fix cmake with gcc) : this is not the …
10d1819 
…good place and the link libs are wrong (@prudhomm @romainhild)
@vincentchabannes
fix forxarding arg
3e56857
@vincentchabannes
fix compilation in doc/manual/laplacian [ci skip]
e679c55
@vincentchabannes
fix compilation of doc/manual/adapt/ [ci skip]
64bc43f
@vincentchabannes
fix compilation of doc/manual/solide/ [ci skip]
77b7e86
@vincentchabannes
some compilation fix in doc [ci skip]
a7c2ae3
@vincentchabannes
enable app with gcc [ci skip]
4fe92f8
@vincentchabannes
some compilation fixes in doc/manual [ci skip]
c1c209d
@vincentchabannes
up named args using non variadic impl
d93cb07
@vincentchabannes
move forward napp
a40c6cb
@vincentchabannes
add gaya machine : need to disable Vtk detection from ParaView (ubunt…
64b3139 
…u package not usable), use vtk ubuntu package
@vincentchabannes
finish compilation fixes in doc/manual [ci skip]
4c23e33
@vincentchabannes
reduce mesh size in test_remesh (test faster) [ci skip]
89e0efe
prudhomm
prudhomm approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@prudhomm prudhomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge work and cleanup!! bravo
I read most of it but probably missed a few things

feelpp/feel/feelalg/matrixpetsc.cpp
@@ -27,7 +27,7 @@
\author Christophe Prud'homme <christophe.prudhomme@feelpp.org>
\date 2008-01-03
*/
#include <boost/timer.hpp>

#include <boost/smart_ptr/make_shared.hpp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about std::make_shared

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this include is probably useless

toolboxes/feel/feelmodels/heat/heat.hpp
@@ -103,6 +103,7 @@ class Heat : public ModelNumerical,
static auto temperature( self_type const* t ) { return ModelFieldTag<self_type,0>( t ); }
};

#if 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be removed no ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I missed this one

@prudhomm prudhomm merged commit 623b978 into develop Nov 23, 2021
@prudhomm
Copy link
Member

@vincentchabannes should the branch be deleted ?

@prudhomm prudhomm added this to the v110 milestone Nov 23, 2021
@vincentchabannes vincentchabannes deleted the feature/named_arguments branch November 24, 2021 15:02
@romainhild romainhild mentioned this pull request Nov 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prudhomm prudhomm prudhomm approved these changes

Assignees

@vincentchabannes vincentchabannes

Labels
cpp17 C++ 17 type:clean-code type:refactoring
Projects
None yet
Milestone
v110
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentchabannes @prudhomm