Support Eigen3 external dependency #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e with debian11 (no use OUTPUT_NAME with interface lib)
prudhomm
approved these changes
Jun 30, 2022
| @@ -693,7 +701,7 @@ if ( FEELPP_ENABLE_TASKFLOW ) | |||
| message(STATUS "[feelpp-taskflow] cmake dir: ${CMAKE_INSTALL_DATADIR}/feel/cmake/modules") | |||
| FetchContent_MakeAvailable(taskflow) | |||
| add_library(feelpp_taskflow INTERFACE) | |||
| set_target_properties(Taskflow PROPERTIES OUTPUT_NAME "feelpp_taskflow") | |||
| #set_target_properties(Taskflow PROPERTIES OUTPUT_NAME "feelpp_taskflow") | |||
There was a problem hiding this comment.
why is it related to the eigen3 dependency issue ?
There was a problem hiding this comment.
I usually rename the libraries to avoid conflicts on the filesystem if there is also an installation of the library
There was a problem hiding this comment.
it's not related. I worked on debian11 and cmake give an error because target Taskflow is an interface lib (and so no OUTPUT_NAME)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the cmake option FEELPP_USE_EXTERNAL_EIGEN3=ON allow to use an eigen3 as an external dependency.
@prudhomm enable this option fix tests on debian11 because Gmsh is compiled with Eigen3 on system and there is a conflict)