-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment text cut #21
base: master
Are you sure you want to change the base?
Comment text cut #21
Conversation
I see, I think the second commit reverts the effects of the first commit. Is there a quick way for me to look at the concatenated diff? |
Just click on files changed tab ? |
He he :). Thanks. Interesting solution. From what I see the tests did not really change. Could you double check please to ensure that we also get a test for this? This is going to be tricky to maintain in the future and we need good test coverage. |
Agreed! Did you try to set up a travis job to ensure the test execution and the coverage on the github? |
Did you have time to work on the tests already? |
I did not had time yet. But I think that configuring properly the travis (with a tag on the readme) + add a test coverage tool like Jacoco could be a first step. |
The build with travis is now setup. I will merge this once the test is added. |
It should be better to see the diff now