Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update causalgraphicalmodels #29

Closed
wants to merge 1 commit into from

Conversation

kvaky
Copy link

@kvaky kvaky commented Feb 5, 2024

The default causalgraphicalmodels version is not compatible with python 3.9+ (issue). The updated version is compatible with python 3.9+

The pinned version is compatible with python 3.9+
@fehiepsi
Copy link
Owner

Thanks, @kvaky! I think it is better to remove the dependency on causalgraphicalmodels. It looks to me that only the Code 6.19 is using it.

Do you think that we can do it with the utilities, like get_model_relations?

@fehiepsi
Copy link
Owner

By the way, the tests are failing because sample_shape is a keyword argument in guide.sample_posterior(...). Do you want to apply the fix to those guide.sample_posterior calls?

@fehiepsi
Copy link
Owner

On a second thought, it seems to me that this could be tricky to use the utility. Let me handle this issue instead. Thanks for pointing it out!

@fehiepsi
Copy link
Owner

I switched to networkx at #31 . Hopefully, it's a more stable solution.

It's quite tricky to get the correct implementation for four variable relations in a causal graph.

@fehiepsi fehiepsi closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants