quote order_by field in SQL #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Changing existing models is fine. I wonder if we shouldn't use |
|
looks like i'm not sure what's going on with the 3.8 and 3.9 tests, though -- is that something you've seen before? if not i'll dig deeper! |
matthiask
added a commit
that referenced
this pull request
Jan 30, 2023
|
The next Django version will drop support for 3.8/3.9. Maybe you could push again so that we can re-check if it works now? |
taobojlen
commented
Jan 30, 2023
| @@ -279,6 +278,8 @@ def as_sql(self, *args, **kwargs): | |||
| if _ordered_by_integer(opts, params) | |||
| else self.CTE_MYSQL_WITH_TEXT_ORDERING | |||
| ) | |||
| if params["order_by"]: | |||
There was a problem hiding this comment.
i'm not sure if order_by can actually be None, but i don't want to risk breaking things for any existing users in case it is.
|
@matthiask yes! done, re-pushed :) |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #51
This allows using an
orderingfield calledorder. Becauseorderis a reserved keyword in SQL, this would cause errors previously.I first reproduced the issue by changing the order field in the test
Model. If you'd rather I create a new test model for this, let me know!I only tested this with postgres locally, so I'm trusting your test suite for other databases. If I can do more to test these, again, please ask :)