Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bloc): resolve analysis warning #3189

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

felangel
Copy link
Owner

@felangel felangel commented Feb 1, 2022

Status

READY

Breaking Changes

NO

Description

  • refactor(bloc): resolve analysis warning

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added pkg:bloc This issue is related to the bloc package refactor Refactor an existing implementation labels Feb 1, 2022
@felangel felangel self-assigned this Feb 1, 2022
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #3189 (4d35613) into master (397314b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #3189    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           30         8    -22     
  Lines          721       193   -528     
==========================================
- Hits           721       193   -528     
Impacted Files Coverage Δ
packages/bloc/lib/src/bloc.dart 100.00% <100.00%> (ø)
packages/bloc/lib/src/emitter.dart 100.00% <100.00%> (ø)
packages/bloc_concurrency/lib/src/restartable.dart
packages/replay_bloc/lib/src/change_stack.dart
packages/flutter_bloc/lib/src/bloc_provider.dart
packages/replay_bloc/lib/src/replay_cubit.dart
...ckages/hydrated_bloc/lib/src/hydrated_storage.dart
...lutter_bloc/lib/src/multi_repository_provider.dart
packages/flutter_bloc/lib/src/bloc_consumer.dart
packages/bloc_test/lib/src/bloc_test.dart
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dae067...4d35613. Read the comment docs.

@felangel felangel merged commit 1af3d7f into master Feb 1, 2022
@felangel felangel deleted the refactor/bloc-analysis-warnings branch February 1, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:bloc This issue is related to the bloc package refactor Refactor an existing implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant