Refactor flutter_bloc to use provider

[felangel]

Status

READY

Breaking Changes

YES

Description

Addresses #354

BlocProvider

• Refactor BlocProvider to extend Provider
• Rename BlocProviderTree to MultiBlocProvider

ImmutableProvider -> RepositoryProvider

• Refactor ImmutableProvider to extend Provider
• Rename ImmutableProvider to RepositoryProvider
• Rename ImmutableProviderTree to MultiRepositoryProvider

BlocListener

• Rename BlocListenerTree to MultiBlocListener

Overall

• Lots of inline documentation updates/improvements

[codecov]

Codecov Report

Merging #385 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #385   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     11    -1     
  Lines         189    174   -15     
=====================================
- Hits          189    174   -15

Impacted Files	Coverage Δ
packages/flutter_bloc/lib/src/bloc_builder.dart	100% <ø> (ø)	⬆️
packages/flutter_bloc/lib/src/bloc_listener.dart	100% <ø> (ø)	⬆️
...ages/flutter_bloc/lib/src/repository_provider.dart	100% <100%> (ø)
...ages/flutter_bloc/lib/src/multi_bloc_provider.dart	100% <100%> (ø)
...lutter_bloc/lib/src/multi_repository_provider.dart	100% <100%> (ø)
packages/flutter_bloc/lib/src/bloc_provider.dart	100% <100%> (ø)	⬆️
...ages/flutter_bloc/lib/src/multi_bloc_listener.dart	100% <100%> (ø)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804a1ae...c0fdc48. Read the comment docs.

[felangel]

@rrousselGit what do you think?

[rrousselGit]

This specific implementation of BlocProvider could be made by subclassing Provider:

class BlocProvider<T extends Bloc> extends Provider<T> {
  BlocProvider(
    Key key,
    @required ValueBuilder<T> builder,
    Widget child,
  ): super(key: key, builder: builder, child: child, dispose: (_, bloc) => bloc.dispose());

  BlocProvider.value(
    Key key,
    @required T value,
    Widget child,
  ): super.value(key: key, value: value, child: child);

  static T of<T extends Bloc>(BuildContext context) {
    ...
  }
}

[rrousselGit]

It may be interesting to subclass MultiProvider too, to help peoples transition from BlocProviderTree and similar.

The mixin shorthand can make it simple:

mixin _NoOp {}

@Deprecated('Use MultiProvider instead')
class BlocProviderTree = MultiProvider with _NoOp;

@Deprecated('Use MultiProvider instead')
class ImmutableProviderTree = MultiProvider with _NoOp;

[felangel]

It may be interesting to subclass MultiProvider too, to help peoples transition from BlocProviderTree and similar.

The mixin shorthand can make it simple:

mixin _NoOp {}

@Deprecated('Use MultiProvider instead')
class BlocProviderTree = MultiProvider with _NoOp;

@Deprecated('Use MultiProvider instead')
class ImmutableProviderTree = MultiProvider with _NoOp;

Since the api would already be different (MultiProvider takes providers instead of blocProviders) I think it might be okay to just call it out as a breaking change.

I'm more concerned about what we're going to do about BlocListenerTree since it's not a provider and doesn't make sense to be used within MultiProvider.

[felangel]

This specific implementation of BlocProvider could be made by subclassing Provider:

class BlocProvider<T extends Bloc> extends Provider<T> {
  BlocProvider(
    Key key,
    @required ValueBuilder<T> builder,
    Widget child,
  ): super(key: key, builder: builder, child: child, dispose: (_, bloc) => bloc.dispose());

  BlocProvider.value(
    Key key,
    @required T value,
    Widget child,
  ): super.value(key: key, value: value, child: child);

  static T of<T extends Bloc>(BuildContext context) {
    ...
  }
}

Thanks for the suggestion 👍

Made the change so now the main thing left to work out is how to replace BlocListenerTree 💯

[axellebot]

BlocListener

• Remove BlocListenerTree

I don't get why removing BlocListenerTree instead of renaming it MultiBlocListener ?

[felangel]

@axellebot I can definitely make that change. It just didn’t seem like BlocListenerTree was being used when I went around asking developers.