Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion error when reading specific file #117

Closed
fratrik opened this issue Oct 1, 2019 · 2 comments · Fixed by #119
Closed

Assertion error when reading specific file #117

fratrik opened this issue Oct 1, 2019 · 2 comments · Fixed by #119
Assignees
@felipenoris
Labels
bug Something isn't working

Comments

@fratrik
Copy link

fratrik commented Oct 1, 2019

I get an assertion error at this line:

https://github.com/felipenoris/XLSX.jl/blob/master/src/stream.jl#L147

when trying to run readxslx on this file.
noutput_first_second_third.xlsx

Debugging shows me that the nodetype and nodename are actionally

debug> EzXML.nodetype(reader)
READER_SIGNIFICANT_WHITESPACE

debug> EzXML.nodename(reader)
"#text"

I wasn't sure what to investigate next.
@felipenoris felipenoris self-assigned this Oct 1, 2019
@felipenoris felipenoris added the bug Something isn't working label Oct 1, 2019
@felipenoris
Copy link
Owner

Thanks! I'll take a look.

felipenoris added a commit that referenced this issue Oct 19, 2019
@felipenoris
fix #117.
a3a0a51 
The problem file had nodes with type READER_SIGNIFICANT_WHITESPACE between every node.
felipenoris added a commit that referenced this issue Oct 19, 2019
@felipenoris
tests for issue #117
0b13cf5
@felipenoris felipenoris mentioned this issue Oct 19, 2019
Merged
@felipenoris
Copy link
Owner

Fixed by 0b13cf5

felipenoris added a commit that referenced this issue Oct 19, 2019
@felipenoris
fix #117.
c5d4b70 
The problem file had nodes with type READER_SIGNIFICANT_WHITESPACE between every node.
felipenoris added a commit that referenced this issue Oct 19, 2019
@felipenoris
tests for issue #117
76b64ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipenoris felipenoris

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fn/fix117 felipenoris/XLSX.jl
2 participants
@fratrik @felipenoris