Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return missing for empty cells of type "s" #109

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

ararslan
Copy link
Contributor

For most other cell data types, we're returning missing if the cell value is empty. The check for emptiness comes after the call to sst_unformatted_string, but sst_unformatted_string calls parse(Int, _) on cell.value, which errors if cell.value is empty. Thus here I've inserted a check in keeping with other branches for isempty(cell.value).

I don't really know anything about the internals of this package (or about the XLSX format) and I'm not sure how to unit test this, but this fixes an issue I encountered.

@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #109 into master will decrease coverage by 0.05%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   95.02%   94.96%   -0.06%     
==========================================
  Files          13       13              
  Lines        1507     1509       +2     
==========================================
+ Hits         1432     1433       +1     
- Misses         75       76       +1
Impacted Files Coverage Δ
src/cell.jl 89.01% <50%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4481de0...0615915. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #109 into master will decrease coverage by 0.05%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   95.02%   94.96%   -0.06%     
==========================================
  Files          13       13              
  Lines        1507     1509       +2     
==========================================
+ Hits         1432     1433       +1     
- Misses         75       76       +1
Impacted Files Coverage Δ
src/cell.jl 89.01% <50%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4481de0...0615915. Read the comment docs.

@felipenoris felipenoris merged commit 9e7ccf8 into felipenoris:master Jul 12, 2019
@ararslan ararslan deleted the aa/sst branch July 12, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants