-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User friendly workaround when trying to get collumns label with badly done table header #164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
=======================================
Coverage 95.10% 95.11%
=======================================
Files 14 14
Lines 1879 1882 +3
=======================================
+ Hits 1787 1790 +3
Misses 92 92
Continue to review full report at Codecov.
|
@felipenoris any chance to get this merged? The "column names must be unique" is the biggest usability issue I regularly encounter with XLSX, and adding a suffix to non-unique names seems an obvious (and widely used in other packages afaik) workaround. |
As me, you could use my personal repo at https://github.com/pascalr0410/XLSX.jl witch is a fork with patched collumn workarround by : using Pkg But the best way would be to integrate my PR or a similar bypass. |
Thank you! |
This PR to implement a user friendly workaround when trying to get collumns label with badly done table header.
In place of the annoyings failleds assertions "Header cell can't be empty" and "Column labels must be unique" it implement the folowing bypass :
Tests cases have been updated accordingly