Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User friendly workaround when trying to get collumns label with badly done table header #164

Merged
merged 11 commits into from
Feb 7, 2022

Conversation

pascalr0410
Copy link
Contributor

This PR to implement a user friendly workaround when trying to get collumns label with badly done table header.

In place of the annoyings failleds assertions "Header cell can't be empty" and "Column labels must be unique" it implement the folowing bypass :

  • Empty cell -> "#Empty"
  • No_unique_label -> No_unique_label#2

Tests cases have been updated accordingly

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #164 (db4e4f3) into master (d2f51a8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   95.10%   95.11%           
=======================================
  Files          14       14           
  Lines        1879     1882    +3     
=======================================
+ Hits         1787     1790    +3     
  Misses         92       92           
Impacted Files Coverage Δ
src/table.jl 94.93% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f51a8...db4e4f3. Read the comment docs.

@nilshg
Copy link

nilshg commented Feb 2, 2022

@felipenoris any chance to get this merged? The "column names must be unique" is the biggest usability issue I regularly encounter with XLSX, and adding a suffix to non-unique names seems an obvious (and widely used in other packages afaik) workaround.

@pascalr0410
Copy link
Contributor Author

As me, you could use my personal repo at https://github.com/pascalr0410/XLSX.jl witch is a fork with patched collumn workarround by :

using Pkg
Pkg.rm("XLSX")
Pkg.add(url="https://github.com/pascalr0410/XLSX.jl")

But the best way would be to integrate my PR or a similar bypass.

@felipenoris felipenoris merged commit 353be0b into felipenoris:master Feb 7, 2022
@nilshg
Copy link

nilshg commented Feb 7, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants