Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Today #62

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Today #62

wants to merge 2 commits into from

Conversation

nebaz
Copy link

@nebaz nebaz commented Aug 29, 2017

  1. text "today" can be a react.element
  2. ability to hide the today button

@felixakiragreen
Copy link
Owner

Thank you for submitting a PR! A few questions before I merge it:

  1. Can you explain the use-case for wanting the text "today" to be a React.element?
  2. If it can be a React.element, does it still make sense for it to be buried in options.format.today or should it be its own prop?

@nebaz
Copy link
Author

nebaz commented Sep 1, 2017

for example, translate text "today" Instantly. To do this, I need to keep the text into react.element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants