Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Contact Form 7 4.6 #40

Merged
merged 10 commits into from
Dec 15, 2016
Merged

Conversation

qutrwp
Copy link
Contributor

@qutrwp qutrwp commented Dec 6, 2016

Adds support for Contact Form 7 version 4.6, as per the release notes below:

http://contactform7.com/2016/12/03/contact-form-7-46/

Tim Christie added 4 commits December 6, 2016 13:18
* bugfix/upgrade-c7-hooks:
  Upgraded to `wpcf7_scan_form_tags`
  Upgraded to `WPCF7_FormTag`
  Upgraded to `wpcf7_add_form_tag`
@felixarntz
Copy link
Owner

Thanks for the PR @qutrwp, and making me aware of that change in Contact Form 7. The PR looks good, however can you please update it to only change the CF7-related stuff? I don't think we should change any function or class names of this CF7BS plugin since it's not necessary.

It's too bad already that CF7 simply changed their function and class names for no obvious reasons. :/

Tim Christie added 2 commits December 8, 2016 11:35
* bugfix/upgrade-c7-hooks:
  Reverted function names to plugin defaults
@qutrwp
Copy link
Contributor Author

qutrwp commented Dec 8, 2016

Hi @felixarntz,

Fair enough - I've updated the PR accordingly.

@zepich
Copy link
Contributor

zepich commented Dec 14, 2016

To be compatible with the latest version of contact form 7 we need also the changes from my pull request to @qutrwp repository (see qutrwp#1).

The WPCF7_FormTagsManger::add() method checks every tag and if a tag already exists the tag will not be overwritten.

qutrwp and others added 3 commits December 15, 2016 09:38
Remove the registered form tags before registring the new ones
* bugfix/upgrade-c7-hooks:
  Standardised indentation
  Remove the registred form tags before registring the new ones
@felixarntz felixarntz merged commit c30bf26 into felixarntz:master Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants