Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filepath.Split instead of path.Split to make this platform independent #16

Merged
merged 1 commit into from
Jan 6, 2019

Conversation

c0d3hub
Copy link

@c0d3hub c0d3hub commented Dec 28, 2018

Hi,
this is a late Christmas gift for your growing swamp fan base of Windows users.
path.Split cannot handle Windows paths (as stated in the docs: https://golang.org/pkg/path/#pkg-overview).
The filepath package however can handle this (https://golang.org/pkg/path/filepath/#pkg-overview).
Wonder how this ever worked for Windows users without specifying AWS_SHARED_CREDENTIALS_FILE env var with a Linux style path to the credentials file..

Cheers,
Christian

@felixb felixb merged commit 6b69223 into felixb:master Jan 6, 2019
@felixb
Copy link
Owner

felixb commented Jan 6, 2019

Thanks!
All windoze user I know, are using the linux version inside an ubuntu subshell or similar. I guess you just met the very first real windoze user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants