Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed raw-tag-access not working #38

Closed
wants to merge 1 commit into from
Closed

Conversation

Naarakah
Copy link

I have fixed a mistake that made raw-tag-access unusable.

@felixc
Copy link
Owner

felixc commented May 18, 2020

Hello again! Thank you very much for the fix!

For my own education, and so I can put it in the commit message for future reference, could you describe the problem and the fix? I'm not familiar enough with Rust FFI to understand the change.

@Naarakah
Copy link
Author

A null pointer was passed to glib_sys::g_bytes_get_data as the argument supposed to be used to return the data size, as I initially thought it was possible (because there's another function to get that size), but the C function behind glib_sys::g_bytes_get_data crashes when given a null pointer so I changed that.

@felixc
Copy link
Owner

felixc commented Jul 12, 2020

Hey! Sorry for the long delay, but this finally landed in f6c90e7.

GitHub doesn't show this PR's status as "merged" because I had to rebase onto some other commits (and I added a test), so I'll have to "close" this — but the change is indeed in master and your contribution is very much appreciated!

@felixc felixc closed this Jul 12, 2020
@felixc felixc added the bug label Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants