Set time and duration of profile #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
reviewed
Apr 28, 2022
kakkoyun
approved these changes
May 9, 2022
felixge
reviewed
Aug 27, 2022
format.go
Outdated
| functionID := uint64(1) | ||
| locationID := uint64(1) | ||
| line := int64(1) | ||
|
|
||
| p := &profile.Profile{} | ||
| m := &profile.Mapping{ID: 1, HasFunctions: true} | ||
| p.Period = int64(1e9 / hz) // Number of nanoseconds between samples. | ||
| p.TimeNanos = startTime.UnixNano() | ||
| p.DurationNanos = endTime.UnixNano() - p.TimeNanos |
There was a problem hiding this comment.
🐞 This is going to produce incorrect results when clock changes or leap seconds are involved. I'll push a fix.
|
Thanks for the patch. Sorry for the late follow-up. I pushed some fixes and merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that not only the duration was missing, but also the timestamp itself.