Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set time and duration of profile #18

merged 6 commits into from Aug 27, 2022


Copy link

@brancz brancz commented Apr 27, 2022

I noticed that not only the duration was missing, but also the timestamp itself.

format.go Outdated Show resolved Hide resolved
format.go Outdated
functionID := uint64(1)
locationID := uint64(1)
line := int64(1)

p := &profile.Profile{}
m := &profile.Mapping{ID: 1, HasFunctions: true}
p.Period = int64(1e9 / hz) // Number of nanoseconds between samples.
p.TimeNanos = startTime.UnixNano()
p.DurationNanos = endTime.UnixNano() - p.TimeNanos
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐞 This is going to produce incorrect results when clock changes or leap seconds are involved. I'll push a fix.

@felixge felixge merged commit 3cad799 into felixge:master Aug 27, 2022
1 check passed
Copy link

felixge commented Aug 27, 2022

Thanks for the patch. Sorry for the late follow-up. I pushed some fixes and merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants