Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed registering plugin bug; updated readme and examples #8

Merged
merged 2 commits into from
Dec 3, 2017

Conversation

tmbarkve
Copy link
Contributor

Tried to install the plugin and got the following exception:

[1] "register" must be a Function
at Object.exports.apply (/home/torstein/tmp/laabr/node_modules/hapi/lib/config.js:22:10)
at internals.Server.register (/home/torstein/tmp/laabr/node_modules/hapi/lib/server.js:364:31)
at __dirname (/home/torstein/tmp/laabr/examples/simple.js:25:18)
at Object. (/home/torstein/tmp/laabr/examples/simple.js:34:3)
at Module._compile (module.js:641:30)
at Object.Module._extensions..js (module.js:652:10)
at Module.load (module.js:560:32)
at tryModuleLoad (module.js:503:12)
at Function.Module._load (module.js:495:3)
at Function.Module.runMain (module.js:682:10)
generatedMessage: false,
name: 'AssertionError [ERR_ASSERTION]',
code: 'ERR_ASSERTION',
actual: false,
expected: true,
operator: '==' }

Updated the plugin registering to match the v.17 API, as well as updated the README.md

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 495a623 on tmbarkve:master into eb916fb on felixheck:master.

@felixheck
Copy link
Owner

Thanks for your contribution — even though it's correct to replace register with plugin, its value should be laabr.plugin because the plugin is exposed through the plugin property. Would be happy if you could test this and change if necessary :)

@tmbarkve
Copy link
Contributor Author

tmbarkve commented Dec 2, 2017

Sorry, my bad, first PR, hence the quality, hehe... Changed laabr to laabr.plugin in examples and README.md - running fine.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1b09678 on tmbarkve:master into eb916fb on felixheck:master.

@felixheck felixheck merged commit cd0c62a into felixheck:master Dec 3, 2017
@felixheck
Copy link
Owner

@tmbarkve thanks for contributing. If there are any further improvements, just proceed ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants