-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: remove dist from the repo #5
Comments
Oh wait, it looks like If |
Yes I would like to ignore the dist folder when pushing to github, but on another hand I need my local git repo to update this folder because I push the app to heroku, this is the examples page. I'm sure there is a way to do that cleanly, I will look into this.
This sounds like the right solution, I want to make the bundled app available somehow, for those who include libraries with script tags. |
Github now has actions and workflows, you can easily automate builds and releases triggered by a tag push |
I love GitHub Actions. Super easy to set up CI, automated tests, etc! |
This has been done. |
Hi all, This library looks cool! However I'm afraid the build file is not accessible at all:
|
Sorry I messed up last time I published, the last patch fixes this : |
Hi @felixmariotto, thanks for the update, it works! Just for info in my case the CommonJS This doesn't work, I get an empty object:
This works:
|
@FredericBriolet thank you for pointing this out !
I also updated the README |
It is an annoyance for most people to have to see diffs that also include the
dist/
folder. Three.js includes thebuild/
folder, but the vast majority of all JavaScript project don't do it.We can build
dist/
for when we publish to NPM (or GitHub releases). People can get the built files fromunpkg.com
.The text was updated successfully, but these errors were encountered: